RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

Fri Apr 7 12:08:49 UTC 2023

On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hello Thomas, that change was based on the review comment here https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942
>
> Okay, Lutz is the expert here. Sorry for the noise.

Just to let my voice be heard directly after being cited several times: s390 is used to designate the CPU architecture. The arch-specific files are stored in src/hotspot/cpu/s390 for that reason. Back in the days when SAP contributed the s390 port, there was a discussion which architecture name to use. SAP had used zArch_64 which more closely reflects what the port really is (a 64-bit only port to IBM's z/Architecture). It was a majority decision to use s390 for some historic reasons (I don't remember exactly anymore).

s390x is (almost) always used in conjunction with a Linux OS port. In that respect, linuxs390x is a tautology. OpenJDK does not use this tautology, see src/hotspot/os_cpu/linux_s390 for example.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1160657249