RFR: 8305089: Implement missing socket options on AIX [v4]

Daniel Fuchs dfuchs at openjdk.org
Fri Apr 14 11:30:36 UTC 2023


On Fri, 14 Apr 2023 10:52:45 GMT, Varada M <duke at openjdk.org> wrote:

>> src/jdk.net/aix/native/libextnet/AIXSocketOptions.c line 130:
>> 
>>> 128: 
>>> 129:     if ((rv=getsockopt(fd, SOL_SOCKET, SO_PEERID, &cred_info, &len)) < 0) {
>>> 130:         handleError(env, rv, "get  failed");
>> 
>> Is the double space after "get  " intended here, or is something missing from the error message?
>
> It is intended

I'm curious, what is the rationale?
By comparison the Linux version has: 

        handleError(env, rv, "get SO_PEERCRED failed");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1166718087



More information about the build-dev mailing list