RFR: 8305089: Implement missing socket options on AIX [v4]

[Daniel Fuchs]

On Fri, 14 Apr 2023 12:09:48 GMT, Varada M <duke at openjdk.org> wrote:

>> Hello Varada, so the Linux version uses `SO_PEERCRED` socket option and when it fails, the error message says "get SO_PEERCRED failed". The AIX version uses `SO_PEERID` and if it fails, the current proposed form in this PR will report the error message as "get  failed" which wouldn't be too informative.
>> 
>> I'm guessing that the reason you didn't include the socket option in the error message is perhaps because the native socket option (on AIX) is `SO_PEERID` but this method is named `getSoPeerCred`. So it might be confusing to report `SO_PEERID` in the error message. Maybe you could change the message to just "getSoPeerCred failed"  instead?
>
> The method name `getSoPeerCred` is the one used in ExtendedSocketOptions.java, which we are overriding here.
> The supported socket option on AIX for is  `SO_PEERID` . I will add `"get SO_PEERID failed"`

For consistency reasons I think I would prefer the message to be "get SO_PEERID failed". All the other methods in this file seem to use the native option name, so let's keep things consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1166757202