RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

Roger Riggs rriggs at openjdk.org
Fri Apr 14 21:38:41 UTC 2023


On Fri, 14 Apr 2023 17:08:10 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> make/modules/java.base/gensrc/GensrcMisc.gmk line 72:
>> 
>>> 70: endif
>>> 71: 
>>> 72: $(eval $(call SetupTextFileProcessing, BUILD_PLATFORMPROPERTIES_JAVA, \
>> 
>> @erikj79 Is there a better/good way to do these mappings, or select "local" variable names?
>
> Not sure if it's better, but you could consider doing this directly in the switch statements in `make/autoconf/platform.m4` and add the corresponding variables in `spec.gmk.in`. That would make them available globally in the build, which may also be detrimental as parts of the build could start relying on them, and we end up with even more variants sprinkled around. I think what you have here is better for now.

ok, I'd rather keep it local.  Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1167290252



More information about the build-dev mailing list