RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]
Amit Kumar
amitkumar at openjdk.org
Wed Apr 19 16:26:02 UTC 2023
On Wed, 19 Apr 2023 13:22:54 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into 8304915-arch-enum
>> - ArchTest on Debian RISC-V 64 confirmed by reviewer
>> - Fixed isPPC64().
>> Consolidated switch cases in ArchTest.
>> Moved mapping of build TARGET_OS and TARGET_CPU to the build
>> to avoid multiple mappings in more than one place.
>> - Correct mapping and test of ppc64
>> - Add ppc64 as mapping to PPC64 Architecture
>> - Modified test to check Architecture is64bits() and isLittleEndian()
>> against Unsafe respective values.
>> Relocated code mapping OS name and arch name from PlatformProps to
>> OperatingSystem and Architecture. Kept the mapping of names
>> in the template close to where the values are filled in by the build.
>> - Remove unused static and import of Stabile
>> - Rename OperatingSystemProps to PlatformProps.
>> Refactor OperatingSystem initialization to use strings instead of integers.
>> - Revised mapping mechanism of build target architecture names to enum values.
>> Unrecognized values from the build are mapped to enum value "OTHER".
>> Renamed PPC64LE to PPC64 to reflect only the architecture, not the endianness.
>> Added an `isLittleEndian` method to return the endianness (not currently used anywhere)
>> - Revert changes to jdk.accessibility AccessBridge
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/8858d543...99a93b7e
>
> test/jdk/jdk/internal/util/ArchTest.java line 71:
>
>> 69: case "aarch64" -> AARCH64;
>> 70: case "riscv64" -> RISCV64;
>> 71: case "s390x", "s390" -> S390; // unverified
>
> This was also verified according to comments. Right, @offamitkumar?
Yes, you're correct @TheRealMDoerr
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1171580811
More information about the build-dev
mailing list