RFR: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed [v2]

[Aleksey Shipilev]

On Fri, 21 Apr 2023 09:00:47 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> We figured that seemingly the correct toolchain could be (and is) already installed by default on Github runners and it makes sense to skip the expensive installation operation which takes some 10+ minutes.
>> 
>> I also tested the scenario with an older toolchain version which would really need installing, e.g. 14.28.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   JDK-8306658
>   
>   GHA: MSVC installation could be optional since it might already be pre-installed

Did it a hard way, huh? This still looks fine to me, with two suggestions. You can do them after the push, not to invalidate the current testing.

.github/workflows/build-windows.yml line 107:

> 105:           '/c/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/vc/auxiliary/build/vcvars64.bat' -vcvars_ver=${{ inputs.msvc-toolset-version }}
> 106:           if [ $? -eq 0 ]; then
> 107:             echo "Toolchain already installed"

"is"

.github/workflows/build-windows.yml line 110:

> 108:             echo "toolchain-installed=true" >> $GITHUB_OUTPUT
> 109:           else
> 110:             echo "Toolchain not yet installed"

"is not"

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13574#pullrequestreview-1395416591
PR Review Comment: https://git.openjdk.org/jdk/pull/13574#discussion_r1173543369
PR Review Comment: https://git.openjdk.org/jdk/pull/13574#discussion_r1173543508