RFR: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed [v3]

Fri Apr 21 17:16:47 UTC 2023

On Fri, 21 Apr 2023 12:21:39 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> We figured that seemingly the correct toolchain could be (and is) already installed by default on Github runners and it makes sense to skip the expensive installation operation which takes some 10+ minutes.
>> 
>> I also tested the scenario with an older toolchain version which would really need installing, e.g. 14.28.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Add review suggestions
>  - Merge branch 'master' into ghastuff
>  - JDK-8306658
>    
>    GHA: MSVC installation could be optional since it might already be pre-installed
>  - JDK-8306543
>    
>    The installation error is probably caused by wrong wrong notation of path for --installPath option

This looks good now. The Linux x86 Test failure is unrelated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13574#issuecomment-1518117716