RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

Thu Apr 27 20:08:31 UTC 2023

On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes based on Erik's feedback
>
> This looks like it should work, but I would like to avoid sprinkling any more CREATING_BUILDJDK conditionals throughout the build than absolutely necessary. I think it would be better to just override `HSDIS_BACKEND` and `ENABLE_HSDIS_BUNDLING` in `buildjdk-spec.gmk.in` with a comment that hsdis should never be enabled in the buildjdk. I haven't tested it though so I may be missing something.

@erikj79 See updated patch. This is indeed cleaner and seems to work (I tried building x64/riscv binaries with/without hsdis).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13697#issuecomment-1526299188