RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

Antonios Printezis tonyp at openjdk.org
Thu Apr 27 20:53:29 UTC 2023


On Thu, 27 Apr 2023 20:37:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes based on Erik's feedback
>
> make/autoconf/buildjdk-spec.gmk.in line 109:
> 
>> 107: # hsdis is not needed
>> 108: override HSDIS_BACKEND := none
>> 109: override ENABLE_HSDIS_BUNDLING := false
> 
> You shouldn't need the `override` keyword. That is only needed when the value of the variables is set on the make command line. In this case we are simply overriding the values from the main `spec.gmk`.

updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13697#discussion_r1179656243



More information about the build-dev mailing list