RFR: 8313274: Failure building java.base-jmod target
Jaikiran Pai
jpai at openjdk.org
Wed Aug 2 07:00:58 UTC 2023
Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8313274?
The commit in this PR reverts the commit that was introduced in https://github.com/openjdk/jdk/pull/14561. Martin, in the 8313274 JBS issue, notes that the failure started happening with that change.
The issue can be consistently reproduced using `--with-jobs=1` during `bash configure` and then triggering a build using `make images`. After the revert of that commit, the build now passes with both `--with-jobs=1` and without the `--with-jobs` option (in which case it uses 8 jobs on my setup).
The other PR where this commit was introduced noted that:
> Fixing this won't impact the build much, but certainly won't hurt either.
which I think meant that the change in that PR is mostly a good to have. Given that it does cause these unexpected failures, the proposal in this PR is to revert that change until we have a better way to do that change (if we want to do it).
tier testing is currently in progress with this change.
-------------
Commit messages:
- Revert "8310379: Relax prerequisites for java.base-jmod target"
Changes: https://git.openjdk.org/jdk/pull/15118/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15118&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8313274
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/15118.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15118/head:pull/15118
PR: https://git.openjdk.org/jdk/pull/15118
More information about the build-dev
mailing list