RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0

Aleksey Shipilev shade at openjdk.org
Wed Aug 2 18:23:50 UTC 2023


On Wed, 2 Aug 2023 02:01:44 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> One warning is disabled for the freetype.

It looks fine, but I have a question that might make the fix more precise:

make/modules/java.desktop/lib/Awt2dLibraries.gmk line 456:

> 454:       EXTRA_HEADER_DIRS := $(BUILD_LIBFREETYPE_HEADER_DIRS), \
> 455:       DISABLED_WARNINGS_microsoft := 4267 4244 4996, \
> 456:       DISABLED_WARNINGS_gcc := maybe-uninitialized dangling-pointer stringop-overflow, \

Is the warning in the widely-used header file? If not, can we disable the warning for the specific compilation units only?  Something like:


DISABLED_WARNINGS_gcc_ftobjs.c := maybe-uninitialized

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15116#pullrequestreview-1559600779
PR Review Comment: https://git.openjdk.org/jdk/pull/15116#discussion_r1282271678



More information about the build-dev mailing list