RFR: 8313274: Failure building java.base-jmod target

[David Holmes]

On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8313274? 
> 
> The commit in this PR reverts the commit that was introduced in https://github.com/openjdk/jdk/pull/14561. Martin, in the 8313274 JBS issue, notes that the failure started happening with that change.
> 
> The issue can be consistently reproduced using `--with-jobs=1` during `bash configure` and then triggering a build using `make images`. After the revert of that commit, the build now passes with both `--with-jobs=1` and without the `--with-jobs` option (in which case it uses 8 jobs on my setup). 
> 
> The other PR where this commit was introduced noted that:
> 
>> Fixing this won't impact the build much, but certainly won't hurt either.
> 
> which I think meant that the change in that PR is mostly a good to have. Given that it does cause these unexpected failures, the proposal in this PR is to revert that change until we have a better way to do that change (if we want to do it).
> 
> tier testing is currently in progress with this change.

Backout looks good but please update the JBS issue as per:
https://openjdk.org/guide/#backing-out-a-change
Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15118#pullrequestreview-1560206983