Integrated: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
Jaikiran Pai
jpai at openjdk.org
Thu Aug 3 07:18:37 UTC 2023
On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8313274?
>
> The commit in this PR reverts the commit that was introduced in https://github.com/openjdk/jdk/pull/14561. Martin, in the 8313274 JBS issue, notes that the failure started happening with that change.
>
> The issue can be consistently reproduced using `--with-jobs=1` during `bash configure` and then triggering a build using `make images`. After the revert of that commit, the build now passes with both `--with-jobs=1` and without the `--with-jobs` option (in which case it uses 8 jobs on my setup).
>
> The other PR where this commit was introduced noted that:
>
>> Fixing this won't impact the build much, but certainly won't hurt either.
>
> which I think meant that the change in that PR is mostly a good to have. Given that it does cause these unexpected failures, the proposal in this PR is to revert that change until we have a better way to do that change (if we want to do it).
>
> tier testing is currently in progress with this change.
This pull request has now been integrated.
Changeset: 3c920f9c
Author: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3c920f9cc61566b7bd08d2bf8773d39a616082d3
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
Reviewed-by: dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/15118
More information about the build-dev
mailing list