RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
Coleen Phillimore
coleenp at openjdk.org
Thu Aug 3 19:18:30 UTC 2023
On Thu, 3 Aug 2023 16:16:12 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> I still don't see the point of using checked_cast if we know that this is only two bits.
>
> As far as I've designed it, only the last two bits of the flags are ever set or used. C++ booleans are either 0 or 1 so the higher bits should never be set.
It is only two bits and the only variable here "is_final_shift" is 1. This could use 1 to make it obvious but the variable is used in the templateInterpreter code. Again, I think this is good. This is never going to be a bug.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15126#discussion_r1283618989
More information about the build-dev
mailing list