RFR: JDK-8313244: NM flags handling in configure process
Christoph Langer
clanger at openjdk.org
Fri Aug 4 09:55:34 UTC 2023
On Fri, 4 Aug 2023 09:22:00 GMT, Andreas Steiner <duke at openjdk.org> wrote:
> On AIX we need the -X64 option for NM in the build. The handling is equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in https://bugs.openjdk.org/browse/JDK-8312466.
Looks good overall. I suggest to remove the BUILD_NM variable in this PR as well. We should then wait with a final review until some folks from the Oracle build team are back.
make/autoconf/flags-other.m4 line 96:
> 94: if test "x$OPENJDK_TARGET_OS" = xaix; then
> 95: NMFLAGS="-X64"
> 96: else
The else case is not needed, as an empty NMFLAGS would be the default. See the handling of RCFLAGS above.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15150#pullrequestreview-1562552521
PR Review Comment: https://git.openjdk.org/jdk/pull/15150#discussion_r1284223066
More information about the build-dev
mailing list