RFR: 8314166: Update googletest to v1.14.0
Thomas Stuefe
stuefe at openjdk.org
Sun Aug 13 06:46:58 UTC 2023
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> As part of the ongoing work to enable -Wconversion with gcc there are a number of occurrences of code in the GoogleTest code itself which need fixing. These have been addressed in version 1.14.0 of GoogleTest. This change is picking up that version, adjusting the relevant build configuration files for GHA and Oracle builds.
>
> Note: This change updates the documentation and configuration so that 1.14.0 is the minimum required version. Strictly speaking 1.14.0 is not required until -Wconversion is _actually_ enabled but since that is presumably just around the corner..
>
> Testing: GHA, tier1-5 (still in progress)
+1
Any chance we can ever go back to keeping the google test suite in the repo? That had been very convenient.
Thanks, Thomas
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15253#pullrequestreview-1575689353
More information about the build-dev
mailing list