RFR: 8314166: Update googletest to v1.14.0 [v2]
Mikael Vidstedt
mikael at openjdk.org
Tue Aug 15 19:56:19 UTC 2023
On Tue, 15 Aug 2023 17:05:28 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
>> As part of the ongoing work to enable -Wconversion with gcc there are a number of occurrences of code in the GoogleTest code itself which need fixing. These have been addressed in version 1.14.0 of GoogleTest. This change is picking up that version, adjusting the relevant build configuration files for GHA and Oracle builds.
>>
>> Note: This change updates the documentation and configuration so that 1.14.0 is the minimum required version. Strictly speaking 1.14.0 is not required until -Wconversion is _actually_ enabled but since that is presumably just around the corner..
>>
>> Testing: GHA, tier1-5 (still in progress)
>
> Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into 8314166-gtest-1.14.0
> - Update googletest to v1.14.0
Thank you for the reviews.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15253#issuecomment-1679512321
More information about the build-dev
mailing list