RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]
    Coleen Phillimore 
    coleenp at openjdk.org
       
    Wed Aug 16 19:16:31 UTC 2023
    
    
  
On Wed, 16 Aug 2023 18:51:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert to use static_cast.
>
> src/hotspot/share/logging/logOutput.cpp line 77:
> 
>> 75:     ntags++;
>> 76:   }
>> 77:   qsort(tags, ntags, sizeof(*tags), (_sort_Fn)tag_cmp);
> 
> While wondering about, then searching for, _sort_Fn, I found it in globalDefinitions.hpp and a wrong comment in instanceKlass.cpp
> 
> 1781:    // _sort_Fn is defined in growableArray.hpp.
> 
> would you mind fixing that comment or removing it?
I removed it, since it seems not helpful.  Thanks for reviewing!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296324419
    
    
More information about the build-dev
mailing list