RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v6]

Dean Long dlong at openjdk.org
Thu Aug 17 00:40:38 UTC 2023


On Wed, 16 Aug 2023 23:56:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion warnings in runtime code.  This is the last one I'm going to do for runtime for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change size of op_index back.

src/hotspot/share/utilities/elfFile.cpp line 1454:

> 1452:         return false;
> 1453:       }
> 1454:       uint8_t operation_advance = checked_cast<uint8_t>(adv);

My reading of the spec is that operation_advance can be large.  I suggest reverting operation_advance changes and just do a checked_cast when assigning op_index.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296561040


More information about the build-dev mailing list