RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev

[Andrew John Hughes]

On Tue, 22 Aug 2023 06:49:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Current GHA bootstraps fail for some arches with the incompatibility between libfreetype-dev and libfreetype6-dev. libfreetype6-dev. Current RISC-V GHA bootstrap fails due to this conflict.
> 
> In both sid and bullseye and sid, libfreetype6-dev is a transitional package:
>   https://packages.debian.org/bullseye/libfreetype6-dev
>   https://packages.debian.org/sid/libfreetype6-dev
> 
> There is therefore no reason to ask for libfreetype6-dev instead of libfreetype-dev. 
> 
> Additional testing:
>  - [ ] GHA

Fix for the issue looks good and tests pass.

As to removing FreeType as a dependency altogether, I think you'd need to pass `--with-freetype=bundled` to the `configure` in `build-cross-compile.yml` as well. By default, it is set to `system` on Linux.
>From `make/autoconf/lib-freetype.m4`:
~~~
  FREETYPE_TO_USE=bundled
  if test "x$OPENJDK_TARGET_OS" != "xwindows" && \
      test "x$OPENJDK_TARGET_OS" != "xmacosx" && \
      test "x$OPENJDK_TARGET_OS" != "xaix"; then
    FREETYPE_TO_USE=system
  fi
~~~

I did notice that this is set for the riscv64 build in `make/conf/jib-profiles.js`

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15378#pullrequestreview-1589283336