RFR: 8314483: Optionally override copyright header in generated source [v2]
Erik Joelsson
erikj at openjdk.org
Fri Aug 25 13:12:44 UTC 2023
On Fri, 25 Aug 2023 06:45:25 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Suggestion from dholmes
>
> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 236:
>
>> 234: case "-jdk-header-template":
>> 235: jdkHeaderTemplate = new String(
>> 236: Files.readAllBytes(Paths.get(args[++i])),
>
> Can `java.nio.file.Files#readString(java.nio.file.Path)` be used instead?
Ah yes, I was looking for that method and didn't find it, but I now realize I was looking in the jdk 8 api. Punished for not setting up an IDE for editing these files. Fixed now, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15346#discussion_r1305638090
More information about the build-dev
mailing list