RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

[Srinivas Vamsi Parasa]

On Mon, 28 Aug 2023 23:29:43 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clean up parameters passed to arrayPartition; update the check to load library
>
> make/modules/java.base/Lib.gmk line 241:
> 
>> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, x86_64)+$(INCLUDE_COMPILER2), true+true+true)
>> 240:   $(eval $(call SetupJdkLibrary, BUILD_LIB_X86_64, \
>> 241:       NAME := x86_64, \
> 
> This looks like a rather generic name for a library. I would expect something a bit more descriptive. 
> 
> I also noted that @vnkozlov questioned needing a separate library for this and I didn't really find an answer. What do we gain from separating this into a separate dynamic library?

Hi Erik, 
As per your suggestion, the name of the library is updated to `libx86_64_sort`. Thank you for fixing the indentation in the build script! 
Please see the changes in the latest commit that was pushed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1312308146