RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

Xiaohong Gong xgong at openjdk.org
Fri Dec 1 01:16:15 UTC 2023


On Thu, 30 Nov 2023 11:13:14 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename vmath to sleef in configure
>
> make/autoconf/lib-sleef.m4 line 56:
> 
>> 54:         AC_MSG_CHECKING([for the specified LIBSLEEF])
>> 55:         if test -e ${with_libsleef}/lib/libsleef.so &&
>> 56:            test -e ${with_libsleef}/include/sleef.h; then
> 
> This fails on my system because libsleef is in `/usr/local/lib64/`. This is the correct place to look according to the Linux FHS. You should _not_ hard-code `/lib`

Did you try to find the libsleef by passing `--with-libsleef=` ? Currently `--with-libsleef=` can only work for people manually built from sleef source code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1411488447


More information about the build-dev mailing list