RFR: 8211238: @Deprecated JFR event [v2]

Alan Bateman alanb at openjdk.org
Sun Dec 3 10:28:44 UTC 2023


On Sat, 2 Dec 2023 17:20:58 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> please help review this enhancement to add a JFR event to report runtime invocations of methods that have been declared deprecated in the JDK.
>> 
>> Testing: jdk_jfr, CI 1-6, stress testing
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8211238' of github.com:mgronlun/jdk into 8211238
>  - reflection support

src/jdk.jfr/share/classes/jdk/jfr/internal/test/DeprecatedThing.java line 90:

> 88:     public static void reflectionForRemoval() {
> 89:         staticCounter++;
> 90:     }

You might want to extend the set of tests to include cases that have the "since" element.  There is a 2x2 matrix of cases to fully exercise the parsing of the RuntimeVisibleAnnotations content.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1413041171


More information about the build-dev mailing list