RFR: JDK-8319413: Start of release updates for JDK 23 [v4]
Iris Clark
iris at openjdk.org
Tue Dec 5 05:40:44 UTC 2023
On Sat, 2 Dec 2023 20:40:57 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update symbol files to JDK 22 b26.
>
> test/langtools/tools/javac/versions/Versions.java line 97:
>
>> 95: TWENTY_ONE(false,"65.0", "21"),
>> 96: TWENTY_TWO(false,"66.0", "22"),
>> 97: TWENTY_THREE(false,"67.0", "23"),
>
> As alignment is broken anyway, let's add space
> Suggestion:
>
> TWENTY_THREE(false, "67.0", "23"),
If you're going to add the space, I'd consider establishing new alignment at TWENTY to accommodate the eventual space needed for "THREE", "SEVEN", and "EIGHT". You wouldn't need to reset alignment for quite some time after that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16505#discussion_r1414904341
More information about the build-dev
mailing list