RFR: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll
Frederic Thevenet
fthevenet at openjdk.org
Fri Dec 8 13:48:15 UTC 2023
On Wed, 6 Dec 2023 18:30:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> When building OpenJDK on the Windows platform, version information are embedded as compiled resources into every native library and executable, which typically contain version numbers, copyright information, product name and vendor name (called "Company name" in this context).
>>
>> Currently, the value for "Company name" is always the same as that of "vendor-name" but it It would be really useful to some build scenarios to allow for the "company name" property embedded in the VersionInfo compiled resources to be different from the "vendor name" property that is used within the JVM (e.g. java -version).
>>
>> This PR adds a "--with-jdk-rc-company-name" configure option which can be used to set "Company name" to its own value, independently of "'vendor-name", in the same fashion as the existing "--with-jdk-rc-name", used to override the values of "File description" and "Product name".
>>
>> If "--with-jdk-rc-company-name" isn't used, then the vendor-name value is used instead, reproducing the same behavior than without this patch.
>
> Marked as reviewed by erikj (Reviewer).
Thanks for the reviews @erikj79 and @magicus.
Could one of you please sponsor this?
Cheers!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16972#issuecomment-1847188041
More information about the build-dev
mailing list