RFR: 8321533: Clang build for Windows

Fri Dec 8 23:20:12 UTC 2023

On Fri, 8 Dec 2023 17:08:33 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> >    And, oh, I must say that I think "clcl" as name for the toolchain is really bad. :-(
>
> It was not my first choice. I tried clang-cl first; the scripts didn't like the dash. Then I tried clangcl, and some of the changes found their way into the MacOS build. findstring is tricky to get right.

Then we need to fix those places. As Erik has commented, `findstring` is usually the wrong function to use when what you really mean is `filter`.

> >    we need to design the integration of clang-cl in a way that we can (hopefully) reuse existing clang warning disables.
> 
> I'd love that. Got any preferences on how that should be handled?

Not straight out of my hat, no. I wonder what would happen as a first step if we started looking at the DISABLE_WARNINGS_clang fields, by just using a hack. I'm guessing this will take some experimenting.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17019#issuecomment-1847960400
PR Comment: https://git.openjdk.org/jdk/pull/17019#issuecomment-1847962061