RFR: 8316657: Support whitebox testing in microbenchmarks

[Claes Redestad]

On Fri, 8 Dec 2023 16:12:27 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has recently arisen.
>
> make/RunTests.gmk line 598:
> 
>> 596:   endif
>> 597: 
>> 598:   # Set paths for dependencies
> 
> @cl4es So basically this is the line you're objecting to? 
> 
> I can remove the change in RunTests.gmk for this patch. That way the wb.jar will be available, but additional work is needed for the micros to access it. But that might, as you say, perhaps be solved within the micros themselves, by annotations or whatever.
> 
> Does that sound reasonable?

More reasonable, yes. If we need to pack the wb.jar into the benchmarks.jar or can reference it from the test image dir remains to be seen, but it would be the responsibility of those micros that need it to set that up. While a fully self-contained solution might be preferred for simplicity, we can assume that our test harnesses have access to the test image and can pull in the associated wb.jar from there if needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16996#discussion_r1422334583