RFR: 8318696: Do not use LFS64 symbols on Linux

[Sam James]

On Tue, 24 Oct 2023 01:36:32 GMT, Sam James <duke at openjdk.org> wrote:

> The LFS64 symbols provided by glibc are not part of any standard and were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). This commit replaces the usage of LFS64 symbols with their regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions will always act as their -64 variants on glibc.

I've already got an OCA processed for MySQL in the past.

I can't see a signup button for the bug tracker so I can't file an issue to include as a link.

Thanks!

I need to pipe config.h through to handle the x86 failure. I'll do that either today or the day after tomorrow.

OK, this should be better now. I've checked with static asserts that the definition propagates and it also errors out without those anyway on incompat. ptr. types.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16329#issuecomment-1776330393
PR Comment: https://git.openjdk.org/jdk/pull/16329#issuecomment-1776334231
PR Comment: https://git.openjdk.org/jdk/pull/16329#issuecomment-1777669228
PR Comment: https://git.openjdk.org/jdk/pull/16329#issuecomment-1777726306
PR Comment: https://git.openjdk.org/jdk/pull/16329#issuecomment-1857301791