RFR: 8318696: Do not use LFS64 symbols on Linux

Magnus Ihse Bursie ihse at openjdk.org
Fri Dec 15 05:34:07 UTC 2023


On Tue, 24 Oct 2023 01:36:32 GMT, Sam James <duke at openjdk.org> wrote:

> The LFS64 symbols provided by glibc are not part of any standard and were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). This commit replaces the usage of LFS64 symbols with their regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions will always act as their -64 variants on glibc.

make/autoconf/configure.ac line 198:

> 196: 
> 197: # Ensure _FILE_OFFSET_BITS is set to 64 for glibc
> 198: AC_SYS_LARGEFILE

We do not use any of the AC_SYS macros in the JDK build. If you want to add `-D_FILE_OFFSET_BITS=64` to the flags, then you need to do so explicitly, at the right location. And you need to decide if it should be added only for Hotspot, only for the JDK native libraries, or both.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16329#discussion_r1389559499


More information about the build-dev mailing list