RFR: 8318696: Do not use LFS64 symbols on Linux

[David Holmes]

On Tue, 24 Oct 2023 01:36:32 GMT, Sam James <duke at openjdk.org> wrote:

> The LFS64 symbols provided by glibc are not part of any standard and were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). This commit replaces the usage of LFS64 symbols with their regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions will always act as their -64 variants on glibc.

I did a bit of archaeology here and have linked a number of existing JBS issues to JDK-8318696.

I don't know the exact history as to why we chose to use LFS64 vs FOB64 (perhaps glibc version limitations?) but it is clear (e.g. from [JDK-8062658](https://bugs.openjdk.org/browse/JDK-8062658)) that there has been confusion about when to use the 64-bit variants in the JDK. For Hotspot I don't see any issue switching to  FOB64 in place of LFS64. So the outlined plan seems good.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16329#issuecomment-1859307211