RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

[Justin King]

On Thu, 2 Feb 2023 05:34:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Support CDS
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> make/data/lsan/lsan_default_options.c line 49:
> 
>> 47: // extremely early during library loading, before main is called.  We need to override the default
>> 48: // options because LSan will perform leak checking at program exit. Unfortunately Hotspot does not
>> 49: // shutdown cleaning at the moment and some leaks occur, we want to ignore these. Instead we
> 
> s/cleaning/cleanly/

Fixed.

> src/hotspot/share/runtime/init.cpp line 198:
> 
>> 196:       VirtualSpaceSummary summary = Universe::heap()->create_heap_space_summary();
>> 197:       LSAN_UNREGISTER_ROOT_REGION(summary.start(), summary.reserved_size());
>> 198:     }
> 
> Again Why is this unconditional? I expected it to be in `#ifdef LEAK_SANITIZER`

Same as other comment. This does more than just the LSAN_*, so I wrapped it now.

> src/hotspot/share/runtime/java.cpp line 432:
> 
>> 430:     static_cast<void>(result);
>> 431:   }
>> 432: 
> 
> Why is this unconditional? I expected it to be in `#ifdef LEAK_SANITIZER`

Since this does a little more than just invoke the LSAN_* macros, that is fair. I wrapped it in an ifdef.

-------------

PR: https://git.openjdk.org/jdk/pull/12229