RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]
David Holmes
dholmes at openjdk.org
Fri Feb 3 08:34:52 UTC 2023
On Fri, 3 Feb 2023 04:26:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Fix grammatical error
>>
>> Signed-off-by: Justin King <jcking at google.com>
>> - Update based on review and remove restriction on compressed oops and class pointers
>>
>> Signed-off-by: Justin King <jcking at google.com>
>
> Updates look good - glad to see the flag changes go away!
>
> I suggest factoring out the change to `test/jdk/jni/nullCaller/exeNullCallerTest.cpp` as it is a JDK test and not part of hotspot. Thanks.
> @dholmes-ora : Do all the sub-data tied to metaspace objects really have to live in C-heap?
@tstuefe - sorry I have no knowledge about that. Perhaps @coleenp can answer?
-------------
PR: https://git.openjdk.org/jdk/pull/12229
More information about the build-dev
mailing list