RFR: 8294982: Implementation of Classfile API [v12]

[Maurizio Cimadamore]

On Fri, 3 Feb 2023 17:46:32 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 346:
> 
>> 344:     public static final int MAGIC_NUMBER = 0xCAFEBABE;
>> 345: 
>> 346:     public static final int NOP             = 0;
> 
> Not sure how I feel about the constants being here. It seems to me that they can be moved to more appropriate places - e.g. Instructor, TypeAnnotation (for the TAT ones), ConstantPool (for the TAG ones).
> 
> The classfile versions, OTOH, do seem to belong here.

Actually, we also have a ClassfileVersion class, so that could be a better place for version numbers?

-------------

PR: https://git.openjdk.org/jdk/pull/10982