RFR: 8294982: Implementation of Classfile API [v12]
Adam Sotona
asotona at openjdk.org
Mon Feb 6 13:02:54 UTC 2023
On Fri, 3 Feb 2023 17:20:19 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/classes/jdk/internal/classfile/TypeAnnotation.java line 617:
>
>> 615: }
>> 616:
>> 617: public static final TypePathComponent ARRAY = new UnboundAttribute.TypePathComponentImpl(Kind.ARRAY, 0);
>
> `public static final` is redundant here (it's an interface) - please check these (I've seen others). E.g. all `public` modifier for types nested in interfaces are redundant as well.
yes, will fix and search for other such cases, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
More information about the build-dev
mailing list