RFR: 8294982: Implementation of Classfile API [v12]

Adam Sotona asotona at openjdk.org
Mon Feb 6 13:58:58 UTC 2023


On Fri, 3 Feb 2023 17:52:49 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/classes/jdk/internal/classfile/AttributedElement.java line 94:
> 
>> 92:      * are permitted.
>> 93:      */
>> 94:     enum Kind {
> 
> Not sure how to interpret this. This seems to refer to an attribute - e.g. where is an attribute allowed - rather than to the element (e.g. the declaration to which the attribute is attached). All the constants are unused, so hard to make sense of how this is used.

There are at least 72 usages of AttributedElement.Kind across the Classfile API.
Do you suggest to rename it to something else (for example Location)?

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list