RFR: 8294982: Implementation of Classfile API [v12]

Adam Sotona asotona at openjdk.org
Mon Feb 6 14:04:58 UTC 2023


On Fri, 3 Feb 2023 17:56:45 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/classes/jdk/internal/classfile/Attributes.java line 774:
> 
>> 772:      */
>> 773:     public static AttributeMapper<?> standardAttribute(Utf8Entry name) {
>> 774:         int hash = name.hashCode();
> 
> If we have a map, why do we need this "inlined" map here? Performance reasons?

Yes, performance is the main reason.
I'll note to do a fresh differential performance benchmarks with a HashMap.

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list