RFR: 8301854: C4819 warnings were reported in libfreetype on Windows
Yasumasa Suenaga
ysuenaga at openjdk.org
Tue Feb 7 02:48:44 UTC 2023
On Tue, 7 Feb 2023 01:12:06 GMT, Phil Race <prr at openjdk.org> wrote:
> but "en_US-iso-8859-1" (eg) definitely should work, because that or some close equivalent (windows cp1252 or maybe 1250) are what we've considered as "must work" (SFAIK)
According to Wikipedia article of [CP1250](https://en.wikipedia.org/wiki/Windows-1250) and [CP1252](https://en.wikipedia.org/wiki/Windows-1252), characters in 9x is not available in [8859-1](https://en.wikipedia.org/wiki/ISO/IEC_8859-1), and I saw this error in `“` (0x93) and `”` (0x94).
So I think to use UTF-8 should be documented, and it is better to add `/utf-8` to `CFLAGS` / `CXXFLAGS` for Windows if we can.
-------------
PR: https://git.openjdk.org/jdk/pull/12436
More information about the build-dev
mailing list