RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

[Magnus Ihse Bursie]

On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
> 
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese locale)
> 
> 
> d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\afscript.h(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
> 
> 
> I added C4819 to DISABLED_WARNINGS_microsoft for libfontmanager and for libfreetype because they are 3rd-party libraries.

I agree with Phil here. This is not the proper solution. As a workaround, you can use the configure arguments to add additional flags to the compiler. Or you can change your locale.

The proper solution is getting the source code base to a consistent UTF-8 format. This is a much larger undertaking, however.

-------------

Changes requested by ihse (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12436