RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

[Justin King]

On Wed, 8 Feb 2023 02:53:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The bot can only check the required number of Reviewers (strictly 1 per OpenJDK rules but changeable as here via `/reviewers` command) but it doesn't know about the informal rules such as having reviewers from each affected area (there is no mapping from people to areas).
> 
> Regardless until your conversation with @tstuefe was complete this was not ready for integration.

>From my point of view it was more questions to clarify how it worked at this point to get to an understanding, rather than specific objections, since the flags were no longer there. Requiring contributors to adhere to informal rules such as who can and cannot approve, and who you should and do not have to wait for, is not ideal. It relies heavily in determining who is part of what group and what group they are reviewing for. Wouldn't it make more sense to tie approval to labels and have reviewers explicitly approve via a command? Or allow reviewers to explicitly require their approval via a command? That way there is no guessing?
It would at least make it explicit and avoid miscommunication. The reviewers themselves are in the best position to know and bump required reviewers, not contributors.

Just my two cents.

-------------

PR: https://git.openjdk.org/jdk/pull/12229