RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

[David Holmes]

On Wed, 8 Feb 2023 13:37:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert changes to JDK
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> I apologize, the fault lies entirely with me. Justin should have no blame in this -- he is not a committer and is not expected to fully know all rules for integration. That responsibility lies with the sponsor, in this case, me.
> 
> I read @dholmes-ora's comment:
>> Updates look good - glad to see the flag changes go away!
> 
>> I suggest factoring out the change to test/jdk/jni/nullCaller/exeNullCallerTest.cpp as it is a JDK test and not part of hotspot. Thanks.
> 
> as an approval from Hotspot, given that the JDK test was removed, which a later commit did indeed remove. And, like Justin, I interpreted Thomas comments as questions that were now answered, rather than an ongoing discussion about the 
> 
> I did not realize there were still an ongoing discussion, and was too eager to sponsor this PR.
> 
> @tstuefe @dholmes-ora Do you want me to revert this change? Or should we continue the discussion in a follow-up bug that can address the remaining problems?

@magicus  no need to backout. Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/12229