RFR: 8302155: [AIX] NUM_LCPU is not required variable [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Feb 13 16:17:34 UTC 2023
On Mon, 13 Feb 2023 15:42:12 GMT, Amit Kumar <duke at openjdk.org> wrote:
>> We don't need NUM_LCPU, it's just a small code change which removes this variable. I've tested it on AIX and cores are detected successfully with changes.
>> @backwaterred please take look at it.
>> Suggestions are welcomed :)
>
> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - addressing comment from magicus
> - Merge branch 'aix_build_variable' of github.com:offamitkumar/jdk into aix_build_variable
> - could be removed
The merge warning from the bots sounded a bit scary; I don't understand what git move you did there, but the end result seems to look fine anyway.
-------------
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12494
More information about the build-dev
mailing list