RFR: 8294982: Implementation of Classfile API [v15]

Wed Feb 15 07:56:56 UTC 2023

On Thu, 9 Feb 2023 12:54:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPool.java line 76:
> 
>> 74:      *              entry
>> 75:      */
>> 76:     BootstrapMethodEntry bootstrapMethodEntry(int index);
> 
> I note some inconsistency in naming - e.g. is `ByIndex` really needed, or a letfover to distinguish between different access modes (which are no longer there, it seems) ?

Yes, there are low-level use cases requiring to operate by index, for example javap.

-------------

PR: https://git.openjdk.org/jdk/pull/10982