RFR: 8294982: Implementation of Classfile API [v15]

[Adam Sotona]

On Thu, 9 Feb 2023 13:01:57 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/classfile/constantpool/ClassEntry.java line 80:
>> 
>>> 78:      * Return a List composed by appending the additions to the base list.
>>> 79:      * @param base The base elements for the list, must not include null
>>> 80:      * @param additions The ClassEntrys to add to the list, must not include null
>> 
>> Perhaps we should use `{@code}` or {@link}` to surround type names (here and elsewhere). `ClassEntrys` looks particularly odd :-)
>
> It is odd to see what is essentially a list append operation in here. IMHO, these helper methods, if needed (I couldn't find uses in the JDK), should probably be added to Collections (which probably means in the jdktypes package for now) - as I don't see anything really ClassEntry/ClassDesc specific about them.

I'll make a note to deeply review javadoc for types and to wrap them, thanks.

As for the List combining methods, they had been proposed, discussed and approved here:
https://github.com/openjdk/jdk-sandbox/pull/35
Feel free to re-open the discussion on mailing list, maybe we can address them better now.
However there is no general contract between "entries" and "symbols" yet, so such methods could be declared generic.

-------------

PR: https://git.openjdk.org/jdk/pull/10982