RFR: JDK-8300531: MSVC CFlags look suspicious [v9]

David Holmes dholmes at openjdk.org
Thu Feb 16 04:02:59 UTC 2023


On Wed, 15 Feb 2023 21:21:47 GMT, Justin King <jcking at openjdk.org> wrote:

>> Update MSVC CFlags to be more consistent with other compilers. Also disables RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert usage of /GR-
>   
>   Signed-off-by: Justin King <jcking at google.com>

I grepp'd the tests and couldn't find anything that appears to be RTTI usage: no dynamic_cast, typeid or type_info. That said use of RTTI in tests is a different matter - tests can use whatever language facilities they need.

-------------

PR: https://git.openjdk.org/jdk/pull/12073



More information about the build-dev mailing list