RFR: JDK-8300531: MSVC CFlags look suspicious [v9]

Ioi Lam iklam at openjdk.org
Thu Feb 16 06:35:27 UTC 2023


On Wed, 15 Feb 2023 21:21:47 GMT, Justin King <jcking at openjdk.org> wrote:

>> Update MSVC CFlags to be more consistent with other compilers. Also disables RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert usage of /GR-
>   
>   Signed-off-by: Justin King <jcking at google.com>

As a general comment, the bug title should be to the point. "Look suspicious" contains no information. It looks like you are changing the optimization level, so the bug title should reflect that.

-------------

Changes requested by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12073



More information about the build-dev mailing list