RFR: 8302460: System C++ Compiler for cross compiling gcc is dangerously wrong

[Magnus Ihse Bursie]

On Tue, 14 Feb 2023 14:32:10 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Full details in linked entry, man did this give me a scare on my local branch
> 
> All C++ compilers for the build operating system are under the name c++ (when selected compiler is gcc), but when searching for BUILD_CXX the compiler given priority is an uppercase CC, and then g++, which is not correct since this simply links to the C compiler instead

I agree. The current title sounds needlessly alarmist.

We're still trying to figure out what changes are suggested, or needed. It sounds like this is about two issues:

1) Change the order in which we look for build C++ compiler
2) On platforms with case-insensitive file systems (like Windows), UTIL_LOOKUP_PROGS is possibly doing the wrong thing

@TheShermanTanker If you agree with this analysis, perhaps the best way forward is to close this PR and the associated bug, and open two new separate bugs?

And if not, you need to be clear what you think the problem is that will not be solved by fixing these two issues.

-------------

PR: https://git.openjdk.org/jdk/pull/12558