RFR: 8294982: Implementation of Classfile API [v20]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Feb 16 11:38:58 UTC 2023


On Thu, 16 Feb 2023 11:27:18 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/CodeRelabeler.java line 43:
> 
>> 41: 
>> 42: /**
>> 43:  * CodeRelabeler is a {@link jdk.internal.classfile.CodeTransform} replacing all occurences
> 
> Suggestion:
> 
>  * CodeRelabeler is a {@link jdk.internal.classfile.CodeTransform} replacing all occurrences

Might want to use `{@code}` (here and elsewhere)

> src/java.base/share/classes/jdk/internal/classfile/components/CodeStackTracker.java line 43:
> 
>> 41: 
>> 42: /**
>> 43:  * CodeStackTracker is a {@link jdk.internal.classfile.CodeTransform} synchronously tracking
> 
> Not sure what is meant by `synchronously`

Might want to use `{@code}` (here and elsewhere)

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list