RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows [v5]
Matthias Baesken
mbaesken at openjdk.org
Fri Feb 17 08:17:52 UTC 2023
On Fri, 17 Feb 2023 05:17:59 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Do not print idle state infos on Windows, print same MHz values for all proces only once
>
> src/hotspot/os/windows/os_windows.cpp line 1915:
>
>> 1913: CurrentMhz != (int) pppi->CurrentMhz ||
>> 1914: MhzLimit != (int) pppi->MhzLimit) {
>> 1915: same_vals_for_all_cpus = false;
>
> You could break once this is false.
Added a break.
> src/hotspot/os/windows/os_windows.cpp line 1924:
>
>> 1922:
>> 1923: if (same_vals_for_all_cpus && MaxMhz != -1) {
>> 1924: st->print_cr("ProcessorInformation for all %d processors :", proc_count);
>
> Nit: Processor Information
I adjusted the output.
-------------
PR: https://git.openjdk.org/jdk/pull/12403
More information about the build-dev
mailing list