RFR: 8294982: Implementation of Classfile API [v20]
Adam Sotona
asotona at openjdk.org
Fri Feb 17 09:15:39 UTC 2023
On Thu, 16 Feb 2023 10:56:57 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/ClassPrinter.java line 93:
>
>> 91: * @return name of the node
>> 92: */
>> 93: public ConstantDesc name();
>
> Not sure about the ConstantDesc here. Why is it better than String?
Type information allows nice rendering for some types in some structured text formats, while `ConstantDesc::toString` is a fallback.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
More information about the build-dev
mailing list